refactor: Use flat structures for morphisms #6791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the symmetry we had in Lean3, where we had `MonoidHom.mk f one mul` not `MonoidHom.mk (OneHom.mk f one) mul`, and `f.toFun` wasn't notation for `f.toMulHom.toFun`. The nesting provided by the previous inheritance is useless to us in the face of `MonoidHomClass.toMonoidHom`, which completely eta-expands the structure anyway.
eric-wieser
added
awaiting-author
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
bors
bot
changed the base branch from
master
to
ScottCarnahan/BinomialRing2
semorrison
changed the base branch from
ScottCarnahan/BinomialRing2
to
master
leanprover-community-mathlib4-bot
added
the
merge-conflict
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the symmetry we had in Lean3, where we had
MonoidHom.mk f one mulnotMonoidHom.mk (OneHom.mk f one) mul, andf.toFunwasn't notation forf.toMulHom.toFun.The nesting provided by the previous inheritance is useless to us in the face of
MonoidHomClass.toMonoidHom, which completely eta-expands the structure anyway.We call the class
FunLikeFlatHack._because this means the field is calledto_which uses up less space in the goal view than any alternative.