[Merged by Bors] - fix(Tactic/ToAdditive): deal with the auxilliary .proof_i and .eq_i declarations
#680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
the
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
…i` declarations (#680) * Also allow `@[to_additive!]`/`@[to_additive?]` and friends without spaces. * I added tiny documentations because of the doc_blame linter. It would be better to use `@[inherit_doc ...]` on the initialization of the `to_additive` attribute, but I don't know the name of that. Help would be appreciated (though this can wait for a later PR). * Add missing documentation in the rest of the file. For the other initialize attributes I copied the Lean 3 documentation that was removed in Lean 4 for some reason. I did not check if the implementation is exactly the same.
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
.proof_i and .eq_i declarations.proof_i and .eq_i declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@[to_additive!]/@[to_additive?]and friends without spaces.@[inherit_doc ...]on the initialization of theto_additiveattribute, but I don't know the name of that. Help would be appreciated (though this can wait for a later PR).