-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: have notation3
use elaborator when generating matchers, add support for pi/lambda
#6833
Conversation
@digama0 Here's something you'd suggested during the review of the first implementation of the |
Thanks a lot for all your work on this! |
…upport for pi/lambda (#6833) `notation3` was generating matchers directly from syntax, which included a half-baked implementation of a term elaborator. This switches to elaborating the term and then generating matchers from the elaborated term. This 1. is more robust and consistent, since it uses the main elaborator and one can make use of other notations 2. has the nice side effect of adding term info to expansions in the `notation3` command 3. can unfortunately generate matchers that are more restrictive than before since they also match against elaborated features such as implicit arguments. We now also generate matchers for expansions that have pi types and lambda expressions.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
notation3
use elaborator when generating matchers, add support for pi/lambdanotation3
use elaborator when generating matchers, add support for pi/lambda
notation3
was generating matchers directly from syntax, which included a half-baked implementation of a term elaborator. This switches to elaborating the term and then generating matchers from the elaborated term. Thisnotation3
commandWe now also generate matchers for expansions that have pi types and lambda expressions.