New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: separate NeZero dependency from Nat/Cast/Defs #6955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
I'm trying to remove any extraneous material from the core definitions in the algebraic hierarchy that are used in tactics. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This continues reducing the import requirements for the basic algebraic hierarchy. In combination with #6954 #6955 #6956 #6957, this reduces the imports for `Mathlib.Algebra.Field.Defs` from * [before.pdf](https://github.com/leanprover-community/mathlib4/files/12518547/before.pdf) * [after.pdf](https://github.com/leanprover-community/mathlib4/files/12518546/after.pdf) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
I'm trying to remove any extraneous material from the core definitions in the algebraic hierarchy that are used in tactics. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This continues reducing the import requirements for the basic algebraic hierarchy. In combination with #6954 #6955 #6956 #6957, this reduces the imports for `Mathlib.Algebra.Field.Defs` from * [before.pdf](https://github.com/leanprover-community/mathlib4/files/12518547/before.pdf) * [after.pdf](https://github.com/leanprover-community/mathlib4/files/12518546/after.pdf) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
I'm trying to remove any extraneous material from the core definitions in the algebraic hierarchy that are used in tactics. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This continues reducing the import requirements for the basic algebraic hierarchy. In combination with #6954 #6955 #6956 #6957, this reduces the imports for `Mathlib.Algebra.Field.Defs` from * [before.pdf](https://github.com/leanprover-community/mathlib4/files/12518547/before.pdf) * [after.pdf](https://github.com/leanprover-community/mathlib4/files/12518546/after.pdf) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
I'm trying to remove any extraneous material from the core definitions in the algebraic hierarchy that are used in tactics.