Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: split Mathlib.Algebra.Invertible #6973

Closed
wants to merge 8 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Sep 6, 2023

Mathlib.Algebra.Invertible is used by fundamental tactics, and this essentially splits it into the part used by NormNum, and everything else.


Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI labels Sep 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 6, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 6, 2023
@jcommelin
Copy link
Member

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Sep 6, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Sep 6, 2023
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 6, 2023
bors bot pushed a commit that referenced this pull request Sep 6, 2023
`Mathlib.Algebra.Invertible` is used by fundamental tactics, and this essentially splits it into the part used by `NormNum`, and everything else.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: split Mathlib.Algebra.Invertible [Merged by Bors] - chore: split Mathlib.Algebra.Invertible Sep 6, 2023
@bors bors bot closed this Sep 6, 2023
@bors bors bot deleted the split_algebra_invertible2 branch September 6, 2023 13:05
ebab pushed a commit that referenced this pull request Sep 11, 2023
`Mathlib.Algebra.Invertible` is used by fundamental tactics, and this essentially splits it into the part used by `NormNum`, and everything else.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
`Mathlib.Algebra.Invertible` is used by fundamental tactics, and this essentially splits it into the part used by `NormNum`, and everything else.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants