Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump to std4#242 #6976

Closed
wants to merge 2 commits into from
Closed

chore: bump to std4#242 #6976

wants to merge 2 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented Sep 6, 2023 •
edited

@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib blocked-by-batt-PR This PR depends on a PR to Batteries awaiting-CI labels Sep 6, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

jcommelin
jcommelin approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

@bors
Copy link

bors bot commented Sep 6, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Sep 6, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:27
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:05
@semorrison semorrison added the dependency-bump This PR bumps the version of an upstream dependency (but not toolchain). label Dec 10, 2023
@semorrison
Copy link
Contributor Author

This has thoroughly rotted because of the delay in reviewing leanprover-community/batteries#242, and it will be easier to just do this fresh when needed.

@semorrison semorrison closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
blocked-by-batt-PR This PR depends on a PR to Batteries blocked-by-other-PR This PR depends on another PR to Mathlib delegated dependency-bump This PR bumps the version of an upstream dependency (but not toolchain). merge-conflict The PR has a merge conflict with master, and needs manual merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @leanprover-community-mathlib4-bot @jcommelin