[Merged by Bors] - fix: let toAdditive handle more auxiliary declarations #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please fix `` in the commit message? |
urkud
reviewed
Nov 24, 2022
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* This PR will correctly deal with names starting with ``env.mainModule ++ `_auxLemma`` (generated by `simp`) * Also add a test for this case (reported on Zulip) * Also correctly deal with equation lemmas, which are have `mkPrivateName env pre` as prefix, instead of `pre`. It fixes both of the following issues: - Previously this would sometimes not translate the equation lemmas, since the naming heuristic didn't change their name - If it would translate a lemma, it would not apply it, since it wasn't additive to the `translations` dictionary. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
* This PR will correctly deal with names starting with ``env.mainModule ++ `_auxLemma`` (generated by `simp`) * Also add a test for this case (reported on Zulip) * Also correctly deal with equation lemmas, which are have `mkPrivateName env pre` as prefix, instead of `pre`. It fixes both of the following issues: - Previously this would sometimes not translate the equation lemmas, since the naming heuristic didn't change their name - If it would translate a lemma, it would not apply it, since it wasn't additive to the `translations` dictionary. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env.mainModule ++ `_auxLemma(generated bysimp)mkPrivateName env preas prefix, instead ofpre. It fixes both of the following issues:translationsdictionary.