[Merged by Bors] - chore: replace anonymous morphism constructors with named fields #7015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
awaiting-CI
t-algebra
eric-wieser
commented
Sep 7, 2023
Comment on lines
-786
to
+787
| protected def subtype : H →* G := | ||
| ⟨⟨((↑) : H → G), rfl⟩, fun _ _ => rfl⟩ | ||
| protected def subtype : H →* G where | ||
| toFun := ((↑) : H → G); map_one' := rfl; map_mul' _ _ := rfl |
There was a problem hiding this comment.
This is a good example of where the angle bracket nesting was just confusing
eric-wieser
commented
Sep 7, 2023
| @@ -19,19 +19,36 @@ variable {G H : Type*} | |||
| def AddEquiv.toMultiplicative [AddZeroClass G] [AddZeroClass H] : | |||
| G ≃+ H ≃ (Multiplicative G ≃* Multiplicative H) where | |||
| toFun f := | |||
| ⟨⟨AddMonoidHom.toMultiplicative f.toAddMonoidHom, | |||
| AddMonoidHom.toMultiplicative f.symm.toAddMonoidHom, f.1.3, f.1.4⟩, f.2⟩ | |||
| invFun f := ⟨⟨f.toMonoidHom, f.symm.toMonoidHom, f.1.3, f.1.4⟩, f.2⟩ | |||
There was a problem hiding this comment.
This was incorrectly-typed
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
leanprover-community-mathlib4-bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
This makes it easier to refactor the order or inheritance structure of morphisms without having to change all of the anonymous constructors. This is far from exhaustive.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
This makes it easier to refactor the order or inheritance structure of morphisms without having to change all of the anonymous constructors. This is far from exhaustive.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
This makes it easier to refactor the order or inheritance structure of morphisms without having to change all of the anonymous constructors. This is far from exhaustive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to refactor the order or inheritance structure of morphisms without having to change all of the anonymous constructors.
This is far from exhaustive.
Multiplicativedefs #7016