Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: complete ProofWidgets bump #7056

Closed
wants to merge 3 commits into from

Conversation

PatrickMassot
Copy link
Member


See discussion on Zulip

Open in Gitpod

@PatrickMassot PatrickMassot added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Sep 9, 2023
@alexjbest
Copy link
Member

maintainer merge

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

🚀 Pull request has been placed on the maintainer queue by alexjbest.

@RemyDegenne
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 9, 2023
bors bot pushed a commit that referenced this pull request Sep 9, 2023
@bors
Copy link

bors bot commented Sep 9, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 9, 2023
@bors
Copy link

bors bot commented Sep 9, 2023

Canceled.

@PatrickMassot
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 9, 2023
Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com>
@bors
Copy link

bors bot commented Sep 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: complete ProofWidgets bump [Merged by Bors] - chore: complete ProofWidgets bump Sep 10, 2023
@bors bors bot closed this Sep 10, 2023
@bors bors bot deleted the pm_better_pw_bump branch September 10, 2023 00:39
@dwrensha
Copy link
Member

After this commit, the mathlib cache seems to no longer work for me:

$ git checkout ae7a2e405 
$ git clean -xffd
$ lake exe cache get
info: cloning https://github.com/leanprover/std4 to ./lake-packages/std
info: cloning https://github.com/gebner/quote4 to ./lake-packages/Qq
info: cloning https://github.com/JLimperg/aesop to ./lake-packages/aesop
info: cloning https://github.com/mhuisi/lean4-cli.git to ./lake-packages/Cli
info: cloning https://github.com/EdAyers/ProofWidgets4 to ./lake-packages/proofwidgets
info: Downloading proofwidgets/v0.0.15/linux-64.tar.gz
info: Unpacking proofwidgets/v0.0.15/linux-64.tar.gz
info: [1/9] Building Cache.IO
info: [2/9] Compiling Cache.IO
info: [2/9] Building Cache.Hashing
info: [3/9] Compiling Cache.Hashing
info: [3/9] Building Cache.Requests
info: [5/9] Compiling Cache.Requests
info: [5/9] Building Cache.Main
info: [7/9] Compiling Cache.Main
info: [9/9] Linking cache
Attempting to download 1026 file(s)
Downloaded: 0 file(s) [attempted 1026/1026 = 100%] (0% success)
Warning: some files were not found in the cache.
This usually means that your local checkout of mathlib4 has diverged from upstream.
If you push your commits to a branch of the mathlib4 repository, CI will build the oleans and they will be available later.
Decompressing 2702 file(s)
unpacked in 1529 ms

$ lake build
[2/5] Building Mathlib.Tactic.PPWithUniv
...
[111/261] Building Mathlib.Tactic.Classical
[119/271] Building Mathlib.Util.AssertExists
[121/274] Building Mathlib.Init.Data.Fin.Basic
[127/274] Building Mathlib.Lean.Expr.Basic
[127/274] Building Mathlib.Tactic.PermuteGoals
[142/379] Building Mathlib.Tactic.Use
[142/380] Building Mathlib.Lean.Meta
[142/380] Building Mathlib.Tactic.GCongr.ForwardAttr
[154/460] Building Mathlib.Tactic.NthRewrite
...
[180/3726] Building Mathlib.Data.Buffer.Parser.Basic
[181/3726] Building Mathlib.Data.Buffer.Parser.Numeral
[183/3726] Building Mathlib.Lean.IO.Process
[183/3726] Building Mathlib.Lean.LocalContext
... (full rebuild )

semorrison added a commit that referenced this pull request Sep 10, 2023
semorrison added a commit that referenced this pull request Sep 10, 2023
The cache is broken after #7044 and #7056, so I am reverting them. (And merging directly, rather than via bors.)
Julian added a commit that referenced this pull request Sep 11, 2023
* fix-lint: (463 commits)
  chore: lint-style.py was calling str.replace incorrectly
  chore: module doc for #find_home, #minimize_imports, import early (#7095)
  chore: reduce imports to Data.Rat.Cast.CharZero (#7091)
  chore: cleanup imports of Data/Rat/Cast/Defs (#7092)
  chore: linarith only needs ring1 (#7090)
  refactor(Data/Int/Bitwise): use `<<<` and `>>>` notation (#6789)
  chore: delete redundant commented-out positivity test (#7085)
  chore: fix docstrings, names and aligns about paracompacity of emetric spaces (#7064)
  feat(Data/Finsupp): add notation (#6367)
  refactor: re-home some meta code (#6921)
  fix: don't use `False` as a bool, use `false` (#7059)
  chore: fix reference to `compactCovering` in docstring (#7065)
  fix: fix link in docstring of IsWellFounded (#7063)
  chore: tidy various files (#7041)
  feat: roots in an algebra (#6740)
  chore: revert ProofWidgets bump in #7044 and #7056 (#7069)
  feat: super factorial (#6768)
  feat(LinearAlgebra/Matrix/Trace): add Matrix.trace_diagonal (#7061)
  chore: complete ProofWidgets bump (#7056)
  feat: More `Finset.sup'` lemmas (#7021)
  feat: self_lt_pow (#7058)
  chore: move some files to `MeasureTheory/MeasurableSpace/` (#7045)
  chore(RingTheory/Nilpotent): untwine two universes (#7057)
  feat: von Neumann Mean Ergodic Theorem (#6053)
  feat: (sSup, Iic) and (Ici, sInf) are Galois connections (#6951)
  feat: derivative along a vector (#7038)
  feat: check for some common git problems in CI (#7043)
  chore: bump ProofWidgets (#7044)
  feat(Topology/Algebra): add `DiscreteTopology Mˣ` (#7028)
  chore: simplify `by rfl` (#7039)
  chore: tidy various files (#7035)
  refactor(LinearAlgebra/CliffordAlgebra/Conjugation): expose implementation details of 'reverse' (#6783)
  feat: add `DiscreteTopology.of_continuous_injective` (#7029)
  feat: restore the module docstring code snippet (#7030)
  feat: flesh out the API for `realPart` and `imaginaryPart` (#7023)
  chore: missing simps lemmas for `Multiplicative` defs (#7016)
  feat: characterize isLittleO on principal filters (#7008)
  doc: cleanup documentation on Basis.constr (#7007)
  feat: cleanup API around differentiable functions (#7004)
  feat: add Nat.digits_append_digits (#6999)
  feat: definition of the homology of a short complex (#6994)
  chore: implement porting notes about Polish spaces (#6991)
  feat(Algebra/Category/ModuleCat): composition of restriction of scalar functors (#6915)
  feat: compute the integral of sqrt (1 - x ^ 2) (#6905)
  chore(*/TensorProduct): missing functorial lemmas (#6781)
  feat: a functor from a small category to a filtered category factors through a small filtered category (#6212)
  feat: expand API on locally integrable functions (#7006)
  chore: split Tactic.NormNum.Basic (#7002)
  feat: a few lemmas on continuous functions (#7005)
  feat: ZMod.castHom_self (#7013)
  ...
bors bot pushed a commit that referenced this pull request Sep 15, 2023
We attempted this previously in #7044 and #7056, but it resulted in a broken cache.

Hopefully that is reproducible on this PR, and we can diagnose and fix before merging!



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
Co-authored-by: Wojciech Nawrocki <wjnawrocki@protonmail.com>
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
The cache is broken after #7044 and #7056, so I am reverting them. (And merging directly, rather than via bors.)
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
We attempted this previously in #7044 and #7056, but it resulted in a broken cache.

Hopefully that is reproducible on this PR, and we can diagnose and fix before merging!



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants