Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: rm @simp from factorial #7078

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: rm @simp from factorial #7078

wants to merge 2 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Sep 10, 2023

Open in Gitpod

@mo271 mo271 mentioned this pull request Sep 10, 2023
Closed
3 tasks
@mo271
Copy link
Collaborator Author

mo271 commented Sep 10, 2023 •
edited

see #6840 and discussion here:
#6806 (comment)

@mo271 mo271 marked this pull request as ready for review September 10, 2023 08:31
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 13, 2023
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 14, 2023
@mo271 mo271 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 14, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 14, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:26
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:05
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 19, 2023
bors bot pushed a commit that referenced this pull request Sep 19, 2023
@mo271
chore: rm @simp from factorial (#7078)
fe39449 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Sep 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: rm @simp from factorial [Merged by Bors] - chore: rm @simp from factorial Sep 19, 2023
@bors bors bot closed this Sep 19, 2023
@bors bors bot deleted the mo271/no_simp_factorial branch September 19, 2023 16:22
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
@mo271 @kodyvajjha
chore: rm @simp from factorial (#7078)
7f9b2e2 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @jcommelin @leanprover-community-mathlib4-bot