-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Port positivity extensions for Nat.ceil
, Int.ceil
, Int.floor
#7089
Closed
Closed
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5920378
feat: port positivity extensions for Int.floor, Nat.ceil, and Int.ceil
dwrensha f814d95
improve error messages
dwrensha c8e7f3a
fix style
dwrensha 8bd7e4b
add universe variable to matches, and make it clearer what is being m…
dwrensha 0364b81
fix types: Zero -> PartialOrder
dwrensha c93b5fe
a better universe
dwrensha 0e01b9a
use eric-wieser's fancier Qq-based code for the Int.floor case
dwrensha e813eac
use fancier Qq-based implementation for Int.ceil
dwrensha b2d35ae
use Qq for the match, at least
dwrensha 2326f9f
remove mkAppM
eric-wieser 5d62133
Merge branch 'master' into positivity-floor
dwrensha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious if there's now any benefit to these; presumably you could inline them in the
q()
s below. Maybe there's a performance benefit with having them separated? cc @semorrison, @gebner.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious too! I kept them like this (as they were in mathlib3) for the sake of making the port as direct as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the point is that in mathlib3, inlining was more painful because there was no
q()
?(hm... but these are all just a single application, so constructing them without
q()
is not very cumbersome at all. So... I'm at a loss)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote the original extensions. It was very hard to make
mk_app
work reliably and I resorted to never use it more than once per term construction. A typical problem is that it would eagerly try to insert thea = 0
argument when I wanted to construct a term of typea ≠ 0
.