Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: reduce imports to Data/Nat/Cast/Basic and Data/Rat/Defs #7093

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - chore: reduce imports to Data/Nat/Cast/Basic and Data/Rat/Defs #7093

wants to merge 6 commits into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI labels Sep 11, 2023
@semorrison semorrison mentioned this pull request Sep 11, 2023
Closed
2 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 11, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 11, 2023
jcommelin
jcommelin approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 11, 2023
@semorrison
Copy link
Contributor Author

bors p=5

@bors
Copy link

bors bot commented Sep 11, 2023

Canceled.

@semorrison
Copy link
Contributor Author

bors merge

bors bot pushed a commit that referenced this pull request Sep 11, 2023
@semorrison
chore: reduce imports to Data/Nat/Cast/Basic and Data/Rat/Defs (#7093)
23cd2ea 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Sep 11, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: reduce imports to Data/Nat/Cast/Basic and Data/Rat/Defs [Merged by Bors] - chore: reduce imports to Data/Nat/Cast/Basic and Data/Rat/Defs Sep 11, 2023
@bors bors bot closed this Sep 11, 2023
@bors bors bot deleted the rat_defs branch September 11, 2023 16:29
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
@semorrison @kodyvajjha
chore: reduce imports to Data/Nat/Cast/Basic and Data/Rat/Defs (#7093)
a8fa0ed 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @jcommelin @leanprover-community-mathlib4-bot