Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - docs: make sub_neg refer to sub_neg_eq_add #7104

Closed
wants to merge 2 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Sep 11, 2023

I'm not a fan of this naming :/


Open in Gitpod

I'm not a fan of this naming :/
@ericrbg ericrbg added documentation Improvements or additions to documentation awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Sep 11, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@ocfnash
Copy link
Contributor

ocfnash commented Sep 12, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 12, 2023
bors bot pushed a commit that referenced this pull request Sep 12, 2023
I'm not a fan of this naming :/
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 12, 2023
I'm not a fan of this naming :/
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed:

@Ruben-VandeVelde
Copy link
Collaborator

I canceled the build because a commit was pushed manually, so bors would have refused to merge, but that seems to have pushed this PR back to the "awaiting review" stage; apologies.

@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed ready-to-merge This PR has been sent to bors. labels Sep 12, 2023
@ocfnash
Copy link
Contributor

ocfnash commented Sep 12, 2023

bors d=ericbg

@bors
Copy link

bors bot commented Sep 12, 2023

✌️ ericBG can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Sep 12, 2023
@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 12, 2023

bors r+

@bors
Copy link

bors bot commented Sep 12, 2023

🔒 Permission denied

Existing reviewers: click here to make ericrbg a reviewer

@ocfnash
Copy link
Contributor

ocfnash commented Sep 12, 2023

bors d=ericrbg

@bors
Copy link

bors bot commented Sep 12, 2023

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 12, 2023

bors r+

bors bot pushed a commit that referenced this pull request Sep 12, 2023
I'm not a fan of this naming :/
@bors
Copy link

bors bot commented Sep 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title docs: make sub_neg refer to sub_neg_eq_add [Merged by Bors] - docs: make sub_neg refer to sub_neg_eq_add Sep 12, 2023
@bors bors bot closed this Sep 12, 2023
@bors bors bot deleted the ericrbg-patch-1 branch September 12, 2023 17:11
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
I'm not a fan of this naming :/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants