[Merged by Bors] - feat: add git origin info to cache .ltar files #7143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
force-pushed
the
ltar_commit
branch
from
5e7c8f2
to
9e8e764
Compare
|
This has been tested on the nightly branch. You won't see any effects on this PR because it doesn't actually touch any mathlib files, so all the cache files are still using the old algorithm. |
digama0
force-pushed
the
ltar_commit
branch
from
9f514e1
to
2be0bd3
Compare
|
bors d+ |
|
✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
This should have no user-visible effects, but from here on `.ltar` files in the cache will contain the commit from which they were generated. Because of the way `cache` works, when you download the cache for a commit you might be using files built from several different commits, because later commits only invalidated some files and the old files are still good. If an `.ltar` file turns out to be bad (e.g. has a surprising `.trace` and is causing `lake build` to ignore it), this is helpful information for debugging, and it's only a few extra bytes in the file. The new version of leantar has a new function: `leantar -k 1234.ltar` will print out the "comments" in the file. If it is a file generated by an old version of leantar it will be empty, but files generated subsequent to this commit will show something along the lines `git=mathlib4@12de34` containing the commit sha for the run that generated this ltar file. Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
This should have no user-visible effects, but from here on `.ltar` files in the cache will contain the commit from which they were generated. Because of the way `cache` works, when you download the cache for a commit you might be using files built from several different commits, because later commits only invalidated some files and the old files are still good. If an `.ltar` file turns out to be bad (e.g. has a surprising `.trace` and is causing `lake build` to ignore it), this is helpful information for debugging, and it's only a few extra bytes in the file. The new version of leantar has a new function: `leantar -k 1234.ltar` will print out the "comments" in the file. If it is a file generated by an old version of leantar it will be empty, but files generated subsequent to this commit will show something along the lines `git=mathlib4@12de34` containing the commit sha for the run that generated this ltar file. Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have no user-visible effects, but from here on
.ltarfiles in the cache will contain the commit from which they were generated. Because of the waycacheworks, when you download the cache for a commit you might be using files built from several different commits, because later commits only invalidated some files and the old files are still good. If an.ltarfile turns out to be bad (e.g. has a surprising.traceand is causinglake buildto ignore it), this is helpful information for debugging, and it's only a few extra bytes in the file.The new version of leantar has a new function:
leantar -k 1234.ltarwill print out the "comments" in the file. If it is a file generated by an old version of leantar it will be empty, but files generated subsequent to this commit will show something along the linesgit=mathlib4@12de34containing the commit sha for the run that generated this ltar file.