-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: tidy up a factorization proof #7164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks! I think this was probably a result of my recent refactor of Multiset.toFinsupp
.
✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with |
This is pretty unavoidable; the important thing is to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
I completely missed that Eric had given it a |
This used to not work because the finsupp poisoned the computability, but it seems fine now. Also slightly tidied it whilst I was there. However, I'm not sure if this is actually wise to keep as something towards `Sort*`: the created term on `k + 2` is not pretty and has an `Eq.mpr`.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
This used to not work because the finsupp poisoned the computability, but it seems fine now. Also slightly tidied it whilst I was there. However, I'm not sure if this is actually wise to keep as something towards `Sort*`: the created term on `k + 2` is not pretty and has an `Eq.mpr`.
This used to not work because the finsupp poisoned the computability, but it seems fine now. Also slightly tidied it whilst I was there.
However, I'm not sure if this is actually wise to keep as something towards
Sort*
: the created term onk + 2
is not pretty and has anEq.mpr
.