Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: tidy up a factorization proof #7164

Closed
wants to merge 4 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Sep 14, 2023

This used to not work because the finsupp poisoned the computability, but it seems fine now. Also slightly tidied it whilst I was there.

However, I'm not sure if this is actually wise to keep as something towards Sort*: the created term on k + 2 is not pretty and has an Eq.mpr.


Open in Gitpod

@ericrbg ericrbg added awaiting-review The author would like community review of the PR awaiting-CI labels Sep 14, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks! I think this was probably a result of my recent refactor of Multiset.toFinsupp.

@bors
Copy link

bors bot commented Sep 14, 2023

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Sep 14, 2023
@eric-wieser
Copy link
Member

However, I'm not sure if this is actually wise to keep as something towards Sort*: the created term on k + 2 is not pretty and has an Eq.mpr.

This is pretty unavoidable; the important thing is to use convert so that there's only one Eq.mpr and not a whole pile of them.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Sep 18, 2023
@ericrbg
Copy link
Collaborator Author

ericrbg commented Sep 18, 2023

I completely missed that Eric had given it a d+ instead of just approving, haha

bors bot pushed a commit that referenced this pull request Sep 18, 2023
This used to not work because the finsupp poisoned the computability, but it seems fine now. Also slightly tidied it whilst I was there.

However, I'm not sure if this is actually wise to keep as something towards `Sort*`: the created term on `k + 2` is not pretty and has an `Eq.mpr`.
@bors
Copy link

bors bot commented Sep 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: tidy up a factorization proof [Merged by Bors] - chore: tidy up a factorization proof Sep 18, 2023
@bors bors bot closed this Sep 18, 2023
@bors bors bot deleted the ericrbg/small_tidy branch September 18, 2023 17:00
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
This used to not work because the finsupp poisoned the computability, but it seems fine now. Also slightly tidied it whilst I was there.

However, I'm not sure if this is actually wise to keep as something towards `Sort*`: the created term on `k + 2` is not pretty and has an `Eq.mpr`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants