-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: nowhere dense and meagre sets #7180
Conversation
One sorry remaining, which should be a simple lemma. (Help welcome in filling this; otherwise I'll do it on Monday or so.) |
bfdf4d2
to
7c0b8b8
Compare
Thanks for the fast review. I've addressed all comments. I've also filled in the last sorry and added the missing import. |
A few comments
|
Sure, I can change both. I'll make these changes once a full review has been performed. |
@Felix-Weilacher I have addressed your comments, and also significantly golfed the proofs. I'm not sure if GDelta.lean is the best file/that file should be renamed now, but it's certainly a decent place. |
d7b20cc
to
d9689a7
Compare
cb5d331
to
176bea0
Compare
Friendly 15-day review ping - just in case this slipped under the radar. I have rebased on latest master and golfed the proof another time; I don't see much leeway of squeezing them further. Suggestions welcome. |
…l sets. Golf some of the proofs.
176bea0
to
8ba9e74
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for some docstrings / declaration names / golfs
…better. And golf two proofs quite a bit.
Thank you for the fast review. I've addressed all comments. |
Thank you again. I have update the code. |
Thanks! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
Thanks! bors merge |
Define nowhere dense and meagre sets and show their basic properties. Meagre sets are defined as the complement of comeagre(=residual) sets (and shown to be equivalent to the standard definition); we deduce their API from the API for comeagre sets. Co-authored-by: grunweg <grunweg@posteo.de>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Define nowhere dense and meagre sets and show their basic properties.
Meagre sets are defined as the complement of comeagre(=residual) sets
(and shown to be equivalent to the standard definition); we deduce their API from the API for comeagre sets.
I'm still pretty new to Lean, hence am open to learning further ways to golf this! :-)
If mathlib prefers American English, I can adjust 😂