Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: nowhere dense and meagre sets #7180

Closed
wants to merge 15 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Sep 15, 2023

Define nowhere dense and meagre sets and show their basic properties.
Meagre sets are defined as the complement of comeagre(=residual) sets
(and shown to be equivalent to the standard definition); we deduce their API from the API for comeagre sets.


I'm still pretty new to Lean, hence am open to learning further ways to golf this! :-)
If mathlib prefers American English, I can adjust 😂

@grunweg grunweg added help-wanted The author needs attention to resolve issues WIP Work in progress awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 15, 2023
@grunweg
Copy link
Collaborator Author

grunweg commented Sep 15, 2023

One sorry remaining, which should be a simple lemma. (Help welcome in filling this; otherwise I'll do it on Monday or so.)
Otherwise ready for review.

@grunweg
Copy link
Collaborator Author

grunweg commented Sep 15, 2023

Thanks for the fast review.

I've addressed all comments. I've also filled in the last sorry and added the missing import.

@grunweg grunweg removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Sep 15, 2023
@Felix-Weilacher
Copy link
Collaborator

Felix-Weilacher commented Sep 16, 2023

A few comments

  • I think starting a new file for Baire category stuff makes sense, but Topology.Meagre is not a good name. Meagreness itself is not distinct enough from residual to have its own file, I think. Maybe Topology.Baire? It might also be correct to put this stuff in Topology.Gdelta. I'm not sure.
  • Because of how central filters are in mathlib, I think it makes more sense to define meagre as "my complement is residual", and then prove that this is equivalent to being contained in a countable union of nowhere dense sets.

@grunweg
Copy link
Collaborator Author

grunweg commented Sep 19, 2023

Sure, I can change both. I'll make these changes once a full review has been performed.

@grunweg
Copy link
Collaborator Author

grunweg commented Sep 22, 2023

@Felix-Weilacher I have addressed your comments, and also significantly golfed the proofs.

I'm not sure if GDelta.lean is the best file/that file should be renamed now, but it's certainly a decent place.

@grunweg grunweg force-pushed the MR-nowhere-dense2 branch 2 times, most recently from d7b20cc to d9689a7 Compare September 22, 2023 14:28
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 9, 2023

Friendly 15-day review ping - just in case this slipped under the radar.

I have rebased on latest master and golfed the proof another time; I don't see much leeway of squeezing them further. Suggestions welcome.

Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some docstrings / declaration names / golfs

Mathlib/Data/Set/Lattice.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 10, 2023

Thank you for the fast review. I've addressed all comments.

Mathlib/Topology/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Topology/GDelta.lean Outdated Show resolved Hide resolved
Mathlib/Data/Set/Lattice.lean Outdated Show resolved Hide resolved
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 10, 2023

Thank you again. I have update the code.

@alreadydone
Copy link
Contributor

alreadydone commented Oct 10, 2023

Thanks!

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@ocfnash
Copy link
Contributor

ocfnash commented Oct 10, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 10, 2023
bors bot pushed a commit that referenced this pull request Oct 10, 2023
Define nowhere dense and meagre sets and show their basic properties.
Meagre sets are defined as the complement of comeagre(=residual) sets
(and shown to be equivalent to the standard definition); we deduce their API from the API for comeagre sets.



Co-authored-by: grunweg <grunweg@posteo.de>
@bors
Copy link

bors bot commented Oct 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: nowhere dense and meagre sets [Merged by Bors] - feat: nowhere dense and meagre sets Oct 10, 2023
@bors bors bot closed this Oct 10, 2023
@bors bors bot deleted the MR-nowhere-dense2 branch October 10, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants