-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Independence of singletons #7251
Conversation
Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade.
This PR/issue depends on:
|
I will review this more thoroughly in the next two days, but right now I can say that it looks like many results could be generalized to independence with respect to a kernel and a measure (like most results about independence). For example, we could have, in Independence/Kernel.lean,
I actually wrote a few of those results for #6098 because I wanted to deduce the conditional independence version. That was before I remembered that you had similar lemmas for independence. If you don't want to generalize the various lemmas yourself, I can do it and push to this PR. Feel free to take from #6098 if you want to do it (I don't think everything is in there, but the example above is). As for butchering "my" file, no worries: I think the API is far from perfect and I would love it if someone else could help put some order to it. |
I had a similar thought about generalizing the results to kernels, but I wasn't sure enough to do it without your advice. I don't know anything about kernels, so i will have to do some reading. |
Sorry, I wrote that I would come back to review more, but the conclusion is simply that this should be generalized and I should have marked it awaiting-author. @YaelDillies, do you mind if I do it and push to this branch? |
Please do! If you don't have time to do it, I can do it myself tonight, since I've now understood what kernels were. |
I've generalized everything to kernel independence. Now we need another reviewer. @JasonKYi perhaps? |
Can you resolve the merge conflict? |
Looks good! |
🚀 Pull request has been placed on the maintainer queue by JasonKYi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade. Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade. Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade.
Rémy, I tried understanding your new independence API but I still feel like I'm butchering your file.
From LeanCamCombi