Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Independence of singletons #7251

Closed
wants to merge 14 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Sep 19, 2023

Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade.


Rémy, I tried understanding your new independence API but I still feel like I'm butchering your file.

From LeanCamCombi

Open in Gitpod

@YaelDillies YaelDillies added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR awaiting-CI t-measure-probability Measure theory / Probability theory labels Sep 19, 2023
@RemyDegenne RemyDegenne self-assigned this Sep 26, 2023
@bors bors bot changed the base branch from generate_from_singleton to master September 26, 2023 13:13
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 26, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 26, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 26, 2023
@RemyDegenne
Copy link
Contributor

RemyDegenne commented Oct 2, 2023

I will review this more thoroughly in the next two days, but right now I can say that it looks like many results could be generalized to independence with respect to a kernel and a measure (like most results about independence). For example, we could have, in Independence/Kernel.lean,

theorem iIndepSets_singleton_iff {s : ι → Set Ω} {_mΩ : MeasurableSpace Ω}
    {κ : kernel α Ω} {μ : Measure α} :
    iIndepSets (fun i ↦ {s i}) κ μ ↔
      ∀ S : Finset ι, ∀ᵐ a ∂μ, κ a (⋂ i ∈ S, s i) = ∏ i in S, κ a (s i) := by

I actually wrote a few of those results for #6098 because I wanted to deduce the conditional independence version. That was before I remembered that you had similar lemmas for independence.

If you don't want to generalize the various lemmas yourself, I can do it and push to this PR. Feel free to take from #6098 if you want to do it (I don't think everything is in there, but the example above is).

As for butchering "my" file, no worries: I think the API is far from perfect and I would love it if someone else could help put some order to it.

@YaelDillies
Copy link
Collaborator Author

I had a similar thought about generalizing the results to kernels, but I wasn't sure enough to do it without your advice.

I don't know anything about kernels, so i will have to do some reading.

@RemyDegenne
Copy link
Contributor

Sorry, I wrote that I would come back to review more, but the conclusion is simply that this should be generalized and I should have marked it awaiting-author. @YaelDillies, do you mind if I do it and push to this branch?

@RemyDegenne RemyDegenne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 30, 2023
@YaelDillies
Copy link
Collaborator Author

Please do! If you don't have time to do it, I can do it myself tonight, since I've now understood what kernels were.

@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 30, 2023
@RemyDegenne
Copy link
Contributor

I've generalized everything to kernel independence. Now we need another reviewer. @JasonKYi perhaps?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 30, 2023
@JasonKYi
Copy link
Member

Can you resolve the merge conflict?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 30, 2023
@JasonKYi
Copy link
Member

Looks good!
maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by JasonKYi.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 31, 2023
bors bot pushed a commit that referenced this pull request Oct 31, 2023
Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade.




Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
@bors
Copy link

bors bot commented Oct 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Independence of singletons [Merged by Bors] - feat: Independence of singletons Oct 31, 2023
@bors bors bot closed this Oct 31, 2023
@bors bors bot deleted the independence_singleton branch October 31, 2023 11:52
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
Port a bit of leanprover-community/mathlib#18506, but it's mostly handmade.




Co-authored-by: RemyDegenne <Remydegenne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants