Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Filtering sups #7254

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: Filtering sups #7254

wants to merge 9 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Sep 19, 2023 •
edited by eric-wieser

Match leanprover-community/mathlib#18612.

The lemmas were already added in #7382, though a slight difference in the statement means that we need a new decidableExistsAndFinsetCoe instance.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged t-order Order hierarchy labels Sep 19, 2023
@jcommelin jcommelin changed the title feat: FIltering sups feat: Filtering sups Sep 19, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 28, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 2, 2023
@eric-wieser
Copy link
Member

Please link to the mathlib3 PR in the description.

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 9, 2023
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 9, 2023
@YaelDillies @eric-wieser
no #noalign
117bba8 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 1, 2023
bors bot pushed a commit that referenced this pull request Nov 1, 2023
@YaelDillies
feat: Filtering sups (#7254)
4bda10c 
Match leanprover-community/mathlib#18612.

The lemmas were already added in #7382, though a slight difference in the statement means that we need a new `decidableExistsAndFinsetCoe` instance.
@bors bors
Copy link

bors bot commented Nov 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Filtering sups [Merged by Bors] - feat: Filtering sups Nov 1, 2023
@bors bors bot closed this Nov 1, 2023
@bors bors bot deleted the truncated_sup branch November 1, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @eric-wieser @leanprover-community-mathlib4-bot