Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: make SimplexCategory.skeletalFunctor a functor to NonemptyFinLinOrdCat.{0} #7272

Closed
wants to merge 5 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Sep 20, 2023

SimplexCategory used to have a universe parameter, but for already some time, it is no longer the case. However, the functor SimplexCategory.skeletalFunctor was still a functor from the simplex category to NonemptyFinLinOrdCat.{v}. This PR changes this to NonemptyFinLinOrdCat.{0}. The main consequence of this is that if C is a category, the n-simplices of the simplicial set nerve C (see AlgebraicTopology.Nerve) are now definitionally equal to Fin (n+1) ⥤ C.


(Previously, there was an annoying ULift.{0,0} when we unfolded the definition of the nerve.)

Open in Gitpod

@joelriou joelriou added t-category-theory Category theory awaiting-review The author would like community review of the PR labels Sep 20, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 23, 2023
@eric-wieser
Copy link
Member

Can you move the PR description above the --- so that it appears in the commit message?

Comment on lines +355 to +356
def skeletalFunctor : SimplexCategory ⥤ NonemptyFinLinOrd where
obj a := NonemptyFinLinOrd.of (Fin (a.len + 1))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the argument here that if you want NonemptyFinLinOrd.{v}, you cam compose with something like NonemptyFinLinOrd.ulift.{v} : NonemptyFinLinOrd.{u} ⥤ .NonemptyFinLinOrd {max u v}?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Comment on lines +392 to +400
{ hom := ⟨f, hf.monotone⟩
inv := ⟨f.symm, _⟩
hom_inv_id := by ext1; apply f.symm_apply_apply
inv_hom_id := by ext1; apply f.apply_symm_apply }
intro i j h
show f.symm i ≤ f.symm j
rw [← hf.le_iff_le]
show f (f.symm i) ≤ f (f.symm j)
simpa only [OrderIso.apply_symm_apply]⟩⟩
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect there's a golf hiding here, but it's probably out of scope

@bors
Copy link

bors bot commented Oct 16, 2023

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 16, 2023
@joelriou
Copy link
Collaborator Author

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 18, 2023
bors bot pushed a commit that referenced this pull request Oct 18, 2023
…nLinOrdCat.{0} (#7272)

`SimplexCategory` used to have a universe parameter, but for already some time, it is no longer the case. However, the functor `SimplexCategory.skeletalFunctor` was still a functor from the simplex category to `NonemptyFinLinOrdCat.{v}`. This PR changes this to `NonemptyFinLinOrdCat.{0}`. The main consequence of this is that if `C` is a category, the `n`-simplices of the simplicial set `nerve C` (see `AlgebraicTopology.Nerve`) are now definitionally equal to `Fin (n+1) ⥤ C`.
@bors
Copy link

bors bot commented Oct 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: make SimplexCategory.skeletalFunctor a functor to NonemptyFinLinOrdCat.{0} [Merged by Bors] - chore: make SimplexCategory.skeletalFunctor a functor to NonemptyFinLinOrdCat.{0} Oct 18, 2023
@bors bors bot closed this Oct 18, 2023
@bors bors bot deleted the simplex_skeletalFunctor_universe_zero branch October 18, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants