-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: make SimplexCategory.skeletalFunctor
a functor to NonemptyFinLinOrdCat.{0}
#7272
Conversation
Can you move the PR description above the |
def skeletalFunctor : SimplexCategory ⥤ NonemptyFinLinOrd where | ||
obj a := NonemptyFinLinOrd.of (Fin (a.len + 1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the argument here that if you want NonemptyFinLinOrd.{v}
, you cam compose with something like NonemptyFinLinOrd.ulift.{v} : NonemptyFinLinOrd.{u} ⥤ .NonemptyFinLinOrd {max u v}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
{ hom := ⟨f, hf.monotone⟩ | ||
inv := ⟨f.symm, _⟩ | ||
hom_inv_id := by ext1; apply f.symm_apply_apply | ||
inv_hom_id := by ext1; apply f.apply_symm_apply } | ||
intro i j h | ||
show f.symm i ≤ f.symm j | ||
rw [← hf.le_iff_le] | ||
show f (f.symm i) ≤ f (f.symm j) | ||
simpa only [OrderIso.apply_symm_apply]⟩⟩ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect there's a golf hiding here, but it's probably out of scope
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
Thanks! bors merge |
…nLinOrdCat.{0} (#7272) `SimplexCategory` used to have a universe parameter, but for already some time, it is no longer the case. However, the functor `SimplexCategory.skeletalFunctor` was still a functor from the simplex category to `NonemptyFinLinOrdCat.{v}`. This PR changes this to `NonemptyFinLinOrdCat.{0}`. The main consequence of this is that if `C` is a category, the `n`-simplices of the simplicial set `nerve C` (see `AlgebraicTopology.Nerve`) are now definitionally equal to `Fin (n+1) ⥤ C`.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
SimplexCategory.skeletalFunctor
a functor to NonemptyFinLinOrdCat.{0}SimplexCategory.skeletalFunctor
a functor to NonemptyFinLinOrdCat.{0}
SimplexCategory
used to have a universe parameter, but for already some time, it is no longer the case. However, the functorSimplexCategory.skeletalFunctor
was still a functor from the simplex category toNonemptyFinLinOrdCat.{v}
. This PR changes this toNonemptyFinLinOrdCat.{0}
. The main consequence of this is that ifC
is a category, then
-simplices of the simplicial setnerve C
(seeAlgebraicTopology.Nerve
) are now definitionally equal toFin (n+1) ⥤ C
.(Previously, there was an annoying
ULift.{0,0}
when we unfolded the definition of the nerve.)