Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix: add .hash files to the cache #7291

Closed
wants to merge 2 commits into from

Conversation

digama0
Copy link
Member

@digama0 digama0 commented Sep 21, 2023

These files are new in v4.1.0. If we don't cache them (or regenerate them, but they are tiny files so there is no reason not to cache them) then lake gets messed up unless you use the -R option in the next lake build.


Open in Gitpod

Cache/IO.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Sep 21, 2023

✌️ digama0 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@digama0
Copy link
Member Author

digama0 commented Sep 21, 2023

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Sep 21, 2023
bors bot pushed a commit that referenced this pull request Sep 21, 2023
These files are new in v4.1.0. If we don't cache them (or regenerate them, but they are tiny files so there is no reason not to cache them) then lake gets messed up unless you use the `-R` option in the next `lake build`.



Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@bors
Copy link

bors bot commented Sep 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix: add .hash files to the cache [Merged by Bors] - fix: add .hash files to the cache Sep 21, 2023
@bors bors bot closed this Sep 21, 2023
@bors bors bot deleted the cache_hash branch September 21, 2023 15:29
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
These files are new in v4.1.0. If we don't cache them (or regenerate them, but they are tiny files so there is no reason not to cache them) then lake gets messed up unless you use the `-R` option in the next `lake build`.



Co-authored-by: Mario Carneiro <di.gama@gmail.com>
bors bot pushed a commit that referenced this pull request Sep 22, 2023
Just recording an explanation from the review of #7291 into the source code.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants