Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add lemma List.getD_map #7307

Closed
wants to merge 6 commits into from

Conversation

BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Sep 21, 2023

Adds a lemma, analogous to Option.getD_map, but for List.

Also fixes a few nearby lemmas to use induction/cases instead of induction'/cases'

Co-authored-by: GitHub Copilot


Open in Gitpod

@BoltonBailey BoltonBailey added the awaiting-review The author would like community review of the PR label Sep 21, 2023
Copy link
Contributor

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if new content used the structured syntax for induction and cases.

@BoltonBailey
Copy link
Collaborator Author

It would be nice if new content used the structured syntax for induction and cases.

Ok, fixed. I also fixed the nearby uses in the file for consistency.

@BoltonBailey BoltonBailey mentioned this pull request Sep 23, 2023
4 tasks
@eric-wieser
Copy link
Member

Please mention that in the PR description

@ocfnash
Copy link
Contributor

ocfnash commented Oct 5, 2023

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 5, 2023
bors bot pushed a commit that referenced this pull request Oct 5, 2023
Adds a lemma, analogous to [Option.getD_map](https://leanprover-community.github.io/mathlib4_docs/Std/Data/Option/Lemmas.html#Option.getD_map), but for `List`.

Also fixes a few nearby lemmas to use `induction`/`cases` instead of `induction'`/`cases'`

~~Co-authored-by: GitHub Copilot~~
@bors
Copy link

bors bot commented Oct 5, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add lemma List.getD_map [Merged by Bors] - feat: add lemma List.getD_map Oct 5, 2023
@bors bors bot closed this Oct 5, 2023
@bors bors bot deleted the BoltonBailey/headd branch October 5, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants