Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: drop redundant LinearMap/LinearEquiv.map_finsupp_sum #7313

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: drop redundant LinearMap/LinearEquiv.map_finsupp_sum #7313

wants to merge 1 commit into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Sep 21, 2023
eric-wieser
eric-wieser approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is probably niche enough to be fine, though in general I often have to resort to LinearMap.map_add over map_add to avoid elaboration issues, so I'd be a little wary of doing this clean up in too many places.

bors d+

@bors
Copy link

bors bot commented Sep 21, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Sep 21, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

bors merge

@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Sep 22, 2023
@Ruben-VandeVelde
chore: drop redundant LinearMap/LinearEquiv.map_finsupp_sum (#7313)
5f0e89d
@bors
Copy link

bors bot commented Sep 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: drop redundant LinearMap/LinearEquiv.map_finsupp_sum [Merged by Bors] - chore: drop redundant LinearMap/LinearEquiv.map_finsupp_sum Sep 22, 2023
@bors bors bot closed this Sep 22, 2023
@bors bors bot deleted the map_finsupp_sum branch September 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @eric-wieser @leanprover-community-mathlib4-bot