New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: the n-th harmonic number is not an integer for n > 1. #7319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't be intimidated by the comments below, they're simple stylistic suggestions
@Ruben-VandeVelde thank you for your comments, I've incorporated most of them and the build passes. @alexjbest suggested that we could move this material out of Counterexamples and into mathlib proper. I could do that as a follow up PR if that works. |
i think i've addressed most of the comments - just waiting now for the build to turn green, thanks everyone! |
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very good. Maybe someone else can take one last look over?
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once those last two comments are taken care of
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
maintainer merge |
🚀 Pull request has been placed on the maintainer queue by alexjbest. |
Thanks for making all these changes @kodyvajjha, hopefully the next PR will be smoother :) |
Hahaha hopefully! Thanks @alexjbest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
The n-th Harmonic number is not an integer for n > 1. This proof uses 2-adic valuations.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
The n-th Harmonic number is not an integer for n > 1. This proof uses 2-adic valuations.
This proof is of Theorem 1 in Keith Conrad's blurb. This proof is credited to Kürschák (1918). From this it follows that the 2-adic valuation of
H_n
tends to infinity asn
does. We quickly run into open problems when similar questions are asked for odd primesp
.