Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: the pretriangulated structure on the opposite category #7336

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: the pretriangulated structure on the opposite category #7336

wants to merge 13 commits into from

Conversation

joelriou
Copy link
Collaborator

(I also have a proof of the octahedron axiom, but compatibilites are still a bit messy.)

Open in Gitpod

@joelriou joelriou added WIP Work in progress t-category-theory Category theory labels Sep 23, 2023
@joelriou joelriou mentioned this pull request Sep 23, 2023
Open
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Sep 23, 2023
jcommelin
jcommelin reviewed Oct 11, 2023
View reviewed changes
Mathlib/CategoryTheory/Triangulated/Opposite.lean

/-- The pretriangulated structure on the opposite category of
a pretriangulated category. -/
scoped instance : Pretriangulated Cᵒᵖ where
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this instance need to be scoped? Can you please document that here, or add a link to some library note that explains it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I have added a comment.

@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 17, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 18, 2023
jcommelin
jcommelin approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 20, 2023
bors bot pushed a commit that referenced this pull request Oct 20, 2023
@joelriou
feat: the pretriangulated structure on the opposite category (#7336)
6f69c1a
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: the pretriangulated structure on the opposite category [Merged by Bors] - feat: the pretriangulated structure on the opposite category Oct 20, 2023
@bors bors bot closed this Oct 20, 2023
@bors bors bot deleted the pretriangulated-op branch October 20, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelriou @jcommelin @erdOne @leanprover-community-mathlib4-bot