chore: bump gh-problem-matcher github action, to silence confusing messages #7346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
easy
|
I was wrong to be so pessimistic about this being resolved upstream so quickly, nice! |
|
I'm not sure this PR is actually needed though. Following the apparent GH actions conventions the v2 tag for problem matcher looks to be already tracking the minor version number also (i.e. v2 now points at v2.02 already) so explicitly pinning this minor version just means we won't automatically receive future improvements. |
alexjbest
added
awaiting-author
|
I just checked some recent logs and indeed I can't see the remove matcher line so indeed this seems like it just pins us to an old version (which doesn't seem helpful to me) |
|
Thanks for catching that, @alexjbest, I hadn't known. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving a confusion reported on zulip, and recently patched in the Github action. liskin/gh-problem-matcher-wrap#16