-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: define the positive Fitting component of the representation of a nilpotent Lie algebra #7360
Conversation
ocfnash
commented
Sep 25, 2023
•
edited
edited
- depends on: [Merged by Bors] - feat: lemmas about divisibility, mostly related to nilpotency #7355
This is very annoying.
This PR/issue depends on: |
This turned out to be easier than expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me. I couldn't find anything to say about the code. If some of this stuff is original research or hard to find in the literature, do you think it's worth mentioning somewhere?
Repeating what I wrote in a now-hidden comment above: I think a small module doc string explanation may be merited when I add the proof of |
Thanks! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by kbuzzard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
…a nilpotent Lie algebra (#7360)
Build failed: |
The build failure was due to a "No space left on device" error for hoskinson9, so I'll try sending this back to bors in the hopes of getting a different runner. bors merge |
…a nilpotent Lie algebra (#7360)
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |