Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: define the positive Fitting component of the representation of a nilpotent Lie algebra #7360

Closed
wants to merge 12 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Sep 25, 2023

@ocfnash ocfnash added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Sep 25, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 25, 2023
This is very annoying.
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Sep 26, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 26, 2023
Mathlib.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 26, 2023
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. I couldn't find anything to say about the code. If some of this stuff is original research or hard to find in the literature, do you think it's worth mentioning somewhere?

Mathlib/Algebra/Lie/Weights.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/Weights.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/Weights.lean Show resolved Hide resolved
@ocfnash
Copy link
Contributor Author

ocfnash commented Oct 5, 2023

This looks great to me. I couldn't find anything to say about the code. If some of this stuff is original research or hard to find in the literature, do you think it's worth mentioning somewhere?

Repeating what I wrote in a now-hidden comment above: I think a small module doc string explanation may be merited when I add the proof of IsCompl (weightSpace M 0) (posFittingComp R L M) (which I have locally but depends on five open PRs).

@kbuzzard
Copy link
Member

kbuzzard commented Oct 6, 2023

Thanks!

maintainer merge

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🚀 Pull request has been placed on the maintainer queue by kbuzzard.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 6, 2023
bors bot pushed a commit that referenced this pull request Oct 6, 2023
@bors
Copy link

bors bot commented Oct 6, 2023

Build failed:

@ocfnash
Copy link
Contributor Author

ocfnash commented Oct 6, 2023

The build failure was due to a "No space left on device" error for hoskinson9, so I'll try sending this back to bors in the hopes of getting a different runner.

bors merge

bors bot pushed a commit that referenced this pull request Oct 6, 2023
@bors
Copy link

bors bot commented Oct 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: define the positive Fitting component of the representation of a nilpotent Lie algebra [Merged by Bors] - feat: define the positive Fitting component of the representation of a nilpotent Lie algebra Oct 6, 2023
@bors bors bot closed this Oct 6, 2023
@bors bors bot deleted the ocfnash/lie_fitting_comp branch October 6, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants