Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: category of $R$-modules has enough injectives #7392

Closed
wants to merge 40 commits into from
Closed

[Merged by Bors] - feat: category of $R$-modules has enough injectives #7392

wants to merge 40 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

Open in Gitpod

@jjaassoonn jjaassoonn added awaiting-review awaiting-CI t-category-theory Category theory t-algebra Algebra (groups, rings, fields etc) labels Sep 26, 2023
@jjaassoonn jjaassoonn changed the title feat: CategoryTheory/Abelian/Transfer transfer enough injectives across an adjunction feat: category of $R$-modules has enough injectives Sep 27, 2023
jjaassoonn and others added 4 commits October 3, 2023 21:33
@joelriou joelriou added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Oct 4, 2023
alreadydone
alreadydone approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, forgotten about this PR.

Mathlib/CategoryTheory/Preadditive/Injective.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean Outdated Show resolved Hide resolved
Mathlib/CategoryTheory/Preadditive/Injective.lean Outdated Show resolved Hide resolved
alreadydone
alreadydone approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@jjaassoonn
Copy link
Collaborator Author

Is it normal that this has been on queue for this long time please? @alreadydone

@alreadydone
Copy link
Contributor

Is it normal that this has been on queue for this long time please?

Sometimes it happens! Maybe one of the maintainers @adamtopaz and @joelriou could take another look and send it to bors?

@mattrobball
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 29, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 29, 2023
@jjaassoonn @alreadydone
feat: category of $R$-modules has enough injectives (#7392)
7ba6897 
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 29, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: category of $R$-modules has enough injectives [Merged by Bors] - feat: category of $R$-modules has enough injectives Nov 29, 2023
@mathlib-bors mathlib-bors bot closed this Nov 29, 2023
@mathlib-bors mathlib-bors bot deleted the zjj/transferEnoughInjectives branch November 29, 2023 19:54
awueth pushed a commit that referenced this pull request Dec 19, 2023
@jjaassoonn @alreadydone @awueth
feat: category of $R$-modules has enough injectives (#7392)
05d63e9 
Co-authored-by: Junyan Xu <junyanxumath@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone approved these changes

@joelriou joelriou joelriou left review comments

@github-actions github-actions[bot] github-actions left review comments

@mattrobball mattrobball mattrobball left review comments

@kbuzzard kbuzzard Awaiting requested review from kbuzzard

@adamtopaz adamtopaz Awaiting requested review from adamtopaz

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jjaassoonn @alreadydone @mattrobball @adamtopaz @joelriou