Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - General valued constraint satisfaction problem defined #7404
[Merged by Bors] - General valued constraint satisfaction problem defined #7404
Changes from 19 commits
67e5b5a
99660ce
eabbed9
e8834ed
0a22003
7d25edd
71dea62
9aa34f5
05d035d
dd15809
cda3275
23403fa
70d57b8
ccf48fd
3697e27
67f962a
d6bbaec
a2f35bf
a329ed9
49219d7
c47bf2d
bec3f58
12dc292
def2137
c678064
a137693
3606d62
5b0ea27
4c4d2c9
c1b123e
e713b2e
81cd487
231a22e
de3037e
ac9d025
8e701f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this comment mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that, in this example (which is here only temporarily and won't be added to mathlib),
True
andFalse
are swapped out of convenience.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the swap. Either way, this instance is bad because mathlib already defines
b1 + b2
asb1 ^^^ b2
, but you define it with||
instead.( I realize it's just here for your example, but I think this makes it a bad example too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have defined an instance that makes
True ≤ False
and so on.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is already an instance that treats plus as xor, it wouldn't be a linear order, right?
My code reuses
Bool.linearOrder
tho.