[Merged by Bors] - feat: add a Module.Finite instance for units of number field #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xroblot
added
WIP
xroblot
added
awaiting-review
xroblot
added
awaiting-review
eric-wieser
reviewed
Sep 28, 2023
eric-wieser
reviewed
Sep 28, 2023
eric-wieser
reviewed
Sep 28, 2023
eric-wieser
reviewed
Sep 28, 2023
riccardobrasca
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
LGTM, thanks!
Can you add Dirichlet's theorem to the library overview, in the number theory section? (Feel free to expand that section as much as you want, it seems really outdated).
Thanks. I'll have a look. |
eric-wieser
reviewed
Sep 29, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
added
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Add the following instance ```lean instance : Module.Finite ℤ (Additive (𝓞 K)ˣ) ``` To prove this instance, it is helpful to add some `rfl` lemmas about `Additive` and `AddMonoidHom.toIntLinearMap` This PR also fixes a couple of typo in the docstring
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Add the following instance ```lean instance : Module.Finite ℤ (Additive (𝓞 K)ˣ) ``` To prove this instance, it is helpful to add some `rfl` lemmas about `Additive` and `AddMonoidHom.toIntLinearMap` This PR also fixes a couple of typo in the docstring
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Add the following instance ```lean instance : Module.Finite ℤ (Additive (𝓞 K)ˣ) ``` To prove this instance, it is helpful to add some `rfl` lemmas about `Additive` and `AddMonoidHom.toIntLinearMap` This PR also fixes a couple of typo in the docstring
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following instance
instance : Module.Finite ℤ (Additive (𝓞 K)ˣ)To prove this instance, it is helpful to add some
rfllemmas aboutAdditiveandAddMonoidHom.toIntLinearMapThis PR also fixes a couple of typo in the docstring