Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: some lemmas about associated and prime elements #7453

Closed
wants to merge 3 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

From flt-regular.

Co-authored-by: Andrew Yang the.erd.one@gmail.com


Open in Gitpod

From flt-regular.

Co-authored-by: Andrew Yang <the.erd.one@gmail.com>
@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Oct 1, 2023
@timotree3
Copy link
Collaborator

Pushed a commit hopefully fixing CI. One of the new lemmas was showing up in the output of a have? test.

@alexjbest
Copy link
Member

LGTM

maintainer merge

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🚀 Pull request has been placed on the maintainer queue by alexjbest.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 2, 2023
bors bot pushed a commit that referenced this pull request Oct 2, 2023
From flt-regular.

Co-authored-by: Andrew Yang <the.erd.one@gmail.com>



Co-authored-by: timotree3 <timorcb@gmail.com>
@@ -60,6 +60,12 @@ theorem dvd_of_dvd_pow (hp : Prime p) {a : α} {n : ℕ} (h : p ∣ a ^ n) : p
exact ih dvd_pow
#align prime.dvd_of_dvd_pow Prime.dvd_of_dvd_pow

theorem dvd_mul {a b : α} : p ∣ a * b ↔ p ∣ a ∨ p ∣ b :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the name contain iff? (Not sure.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if we also change Nat.Prime.dvd_mul

@bors
Copy link

bors bot commented Oct 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: some lemmas about associated and prime elements [Merged by Bors] - feat: some lemmas about associated and prime elements Oct 2, 2023
@bors bors bot closed this Oct 2, 2023
@bors bors bot deleted the primes branch October 2, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants