Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: fix some cases in names #7469

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore: fix some cases in names #7469

wants to merge 5 commits into from

Conversation

alexjbest
Copy link
Member

@alexjbest alexjbest commented Oct 2, 2023 •
edited

And fix some names in comments where this revealed issues

Open in Gitpod

@alexjbest alexjbest added awaiting-review The author would like community review of the PR awaiting-CI labels Oct 2, 2023
alexjbest
alexjbest commented Oct 2, 2023
View reviewed changes
test/toAdditive.lean Outdated Show resolved Hide resolved
alexjbest
alexjbest commented Oct 2, 2023
View reviewed changes
test/toAdditive.lean Outdated Show resolved Hide resolved
@alexjbest alexjbest added the documentation Improvements or additions to documentation label Oct 3, 2023
riccardobrasca
riccardobrasca reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!! I wonder when this kind of things will be completely done...

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 4, 2023
bors bot pushed a commit that referenced this pull request Oct 4, 2023
@alexjbest
chore: fix some cases in names (#7469)
be0d066 
And fix some names in comments where this revealed issues
@alexjbest
Copy link
Member Author

I got about halfway through my grep search before I got bored, so certainly not yet but hopefully it isn't too far

@bors
Copy link

bors bot commented Oct 4, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: fix some cases in names [Merged by Bors] - chore: fix some cases in names Oct 4, 2023
@bors bors bot closed this Oct 4, 2023
@bors bors bot deleted the alexjbest/fixnames branch October 4, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexjbest @riccardobrasca @leanprover-community-mathlib4-bot