Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: reduce FLT to odd primes #7485

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: reduce FLT to odd primes #7485

wants to merge 5 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Oct 3, 2023
tb65536
tb65536 reviewed Oct 3, 2023
View reviewed changes
Mathlib/Data/Nat/Factors.lean Outdated Show resolved Hide resolved
Mathlib/Data/Nat/Factors.lean Outdated Show resolved Hide resolved
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 12, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 12, 2023
tb65536
tb65536 reviewed Oct 12, 2023
View reviewed changes
Mathlib/NumberTheory/FLT/Four.lean
theorem FermatLastTheorem.of_odd_primes
(hprimes : ∀ p : ℕ, Nat.Prime p → Odd p → FermatLastTheoremFor p) : FermatLastTheorem := by
intro n h
rw [ge_iff_le, Nat.succ_le_iff] at h
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to change the definition of FLT to 2 < n?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the library it seems we use odd (for example Nat.Prime.eq_two_or_odd'), so I guess it makes sense to use it also here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, odd is totally fine. I was meaning something like this: #7869

tb65536
tb65536 approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@tb65536 tb65536 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

riccardobrasca
riccardobrasca reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@riccardobrasca riccardobrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 23, 2023
bors bot pushed a commit that referenced this pull request Oct 23, 2023
@Ruben-VandeVelde
feat: reduce FLT to odd primes (#7485)
37079e5
@bors
Copy link

bors bot commented Oct 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: reduce FLT to odd primes [Merged by Bors] - feat: reduce FLT to odd primes Oct 23, 2023
@bors bors bot closed this Oct 23, 2023
@bors bors bot deleted the flt-of-odd-primes branch October 23, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@tb65536 tb65536 tb65536 approved these changes

@riccardobrasca riccardobrasca riccardobrasca left review comments

@kbuzzard kbuzzard Awaiting requested review from kbuzzard

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @jcommelin @tb65536 @riccardobrasca @leanprover-community-mathlib4-bot