Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: improve API for Fitting decomposition of a linear endomorphism #7487

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: improve API for Fitting decomposition of a linear endomorphism #7487

wants to merge 6 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Oct 3, 2023

Especially the new lemma LinearMap.eventually_isCompl_ker_pow_range_pow

Open in Gitpod

@ocfnash
feat: improve API for Fitting decomposition of a linear endomorphism
1faf81e 
Especially the new lemma `LinearMap.eventually_isCompl_ker_pow_range_pow`
@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Oct 3, 2023
@alexjbest
Copy link
Member

Can we add the words "Fitting decomposition" or Fitting lemma somewhere appropriate in the code? It seems odd that the only references to the naming would be in PR / commit messages and I can't see any reference to "fitting" in mathlib

@ocfnash
Copy link
Contributor Author

ocfnash commented Oct 5, 2023

Can we add the words "Fitting decomposition" or Fitting lemma somewhere appropriate in the code? It seems odd that the only references to the naming would be in PR / commit messages and I can't see any reference to "fitting" in mathlib

Good point; done in cd1ff11

ocfnash
ocfnash commented Oct 6, 2023
View reviewed changes
Mathlib/RingTheory/Artinian.lean
@@ -267,15 +306,6 @@ theorem disjoint_partial_infs_eventually_top (f : ℕ → Submodule R M)
exact (h m).eq_bot_of_ge (sup_eq_left.1 <| (w (m + 1) <| le_add_right p).symm.trans <| w m p)
#align is_artinian.disjoint_partial_infs_eventually_top IsArtinian.disjoint_partial_infs_eventually_top

lemma _root_.LinearMap.exists_range_pow_eq_iInf (f : Module.End R M) :
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed because it has been replaced by the more powerful (and more useful) lemma: LinearMap.eventually_iInf_range_pow_eq (above).

@ocfnash ocfnash mentioned this pull request Oct 6, 2023
Closed
eric-wieser
eric-wieser approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but someone with more experience using filters than me should probably give a final look.

maintainer merge

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

@PatrickMassot
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Oct 10, 2023

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 10, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Oct 10, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 10, 2023
bors bot pushed a commit that referenced this pull request Oct 10, 2023
@ocfnash
feat: improve API for Fitting decomposition of a linear endomorphism (#…
b400da1 
…7487)

Especially the new lemma `LinearMap.eventually_isCompl_ker_pow_range_pow`
@bors
Copy link

bors bot commented Oct 11, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: improve API for Fitting decomposition of a linear endomorphism [Merged by Bors] - feat: improve API for Fitting decomposition of a linear endomorphism Oct 11, 2023
@bors bors bot closed this Oct 11, 2023
@bors bors bot deleted the ocfnash/fitting_decomp branch October 11, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocfnash @alexjbest @PatrickMassot @eric-wieser