Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - style: rename Stream'.nth to Stream'.get #7514

Closed
wants to merge 5 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Oct 5, 2023

Many of nth (e.g. list.nth, stream.seq.nth) are renamed to get? in Mathlib 4, but Stream'.nth had been remained as it.


Open in Gitpod

@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI labels Oct 5, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting this into a separate PR. I don't have strong opinion about nth vs get, but your argument seems pretty reasonable.

maintainer merge

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

🚀 Pull request has been placed on the maintainer queue by eric-wieser.

@kmill
Copy link
Contributor

kmill commented Oct 20, 2023

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 20, 2023
bors bot pushed a commit that referenced this pull request Oct 20, 2023
Many of `nth` (e.g. `list.nth`, `stream.seq.nth`) are renamed to `get?` in Mathlib 4, but `Stream'.nth` had been remained as it.
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title style: rename Stream'.nth to Stream'.get [Merged by Bors] - style: rename Stream'.nth to Stream'.get Oct 20, 2023
@bors bors bot closed this Oct 20, 2023
@bors bors bot deleted the Komyyy/Stream'.get branch October 20, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants