Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: fix aligns #7529

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: fix aligns #7529

wants to merge 2 commits into from

Conversation

mariainesdff
Copy link
Collaborator

Open in Gitpod

@mariainesdff mariainesdff added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 5, 2023
@ADedecker
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 5, 2023
bors bot pushed a commit that referenced this pull request Oct 5, 2023
@mariainesdff
chore: add and fix aligns (#7529)
c7515d8
eric-wieser
eric-wieser reviewed Oct 5, 2023
View reviewed changes
Mathlib/Order/Lattice.lean Outdated
@@ -1169,10 +1169,12 @@ theorem map_sup [SemilatticeSup β] (hf : MonotoneOn f s) (hx : x ∈ s) (hy : y
first
| assumption
| simp only [*, sup_of_le_left, sup_of_le_right]
#align monotone_on.map_sup MonotoneOn.map_sup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r-

I think this belongs in #6339, which is a forward-port of these lemmas.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(what happened here is that the lemmas were independently added to mathlib3 and mathlib4)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I have removed these aligns. (Since I was already fixing some aligns, when I saw this question it made sense to me to also add these).

@bors
Copy link

bors bot commented Oct 5, 2023

Canceled.

@mariainesdff mariainesdff added awaiting-review The author would like community review of the PR and removed ready-to-merge This PR has been sent to bors. labels Oct 6, 2023
@mariainesdff mariainesdff changed the title chore: add and fix aligns chore: fix aligns Oct 6, 2023
@ADedecker
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 7, 2023
bors bot pushed a commit that referenced this pull request Oct 7, 2023
@mariainesdff
chore: fix aligns (#7529)
81fa8d9
@eric-wieser eric-wieser mentioned this pull request Oct 7, 2023
Closed
@bors
Copy link

bors bot commented Oct 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: fix aligns [Merged by Bors] - chore: fix aligns Oct 7, 2023
@bors bors bot closed this Oct 7, 2023
@bors bors bot deleted the mariainesdff/align branch October 7, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mariainesdff @ADedecker @eric-wieser