Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - perf (Filter.Germ): direct inheritance patterns for instances #7540

Closed
wants to merge 4 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Oct 6, 2023

We replace uses of Function.Surjective.x with terms constructed using direct inheritance from parents.


Open in Gitpod

@mattrobball
Copy link
Collaborator Author

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 09bf169.
There were significant changes against commit 63e3334:

  Benchmark                                                          Metric         Change
  ========================================================================================
+ ~Mathlib.MeasureTheory.Function.ConditionalExpectation.CondexpL1   instructions    -6.2%
+ ~Mathlib.MeasureTheory.Function.ConditionalExpectation.CondexpL2   instructions   -35.8%
+ ~Mathlib.MeasureTheory.Function.LpSpace                            instructions   -13.1%
+ ~Mathlib.Order.Filter.FilterProduct                                instructions   -19.8%
+ ~Mathlib.Order.Filter.Germ                                         instructions   -24.4%

@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label Oct 6, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 9, 2023
bors bot pushed a commit that referenced this pull request Oct 9, 2023
We replace uses of `Function.Surjective.x` with terms constructed using direct inheritance from parents.
@bors
Copy link

bors bot commented Oct 9, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title perf (Filter.Germ): direct inheritance patterns for instances [Merged by Bors] - perf (Filter.Germ): direct inheritance patterns for instances Oct 9, 2023
@bors bors bot closed this Oct 9, 2023
@bors bors bot deleted the mrb/germs_instances branch October 9, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants