Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Num): use bitwise notation #7593

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Oct 9, 2023

This enables the existing |||, &&&, <<<, >>>, and ^^^ notation for Num and PosNum, and makes them simp-normal form.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI labels Oct 9, 2023
@tobiasgrosser
Copy link
Collaborator

That looks very useful to me @eric-wieser.

@eric-wieser
Copy link
Member Author

@tobiasgrosser: once #7451 goes in, we can do the same thing for Nat.xor and friends

@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 12, 2023
bors bot pushed a commit that referenced this pull request Oct 12, 2023
This enables the existing `|||`, `&&&`, `<<<`, `>>>`, and `^^^` notation for `Num` and `PosNum`, and makes them simp-normal form.
@bors
Copy link

bors bot commented Oct 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(Data/Num): use bitwise notation [Merged by Bors] - feat(Data/Num): use bitwise notation Oct 12, 2023
@bors bors bot closed this Oct 12, 2023
@bors bors bot deleted the num-bit-notation branch October 12, 2023 13:20
grunweg pushed a commit that referenced this pull request Oct 13, 2023
This enables the existing `|||`, `&&&`, `<<<`, `>>>`, and `^^^` notation for `Num` and `PosNum`, and makes them simp-normal form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants