[Merged by Bors] - refactor(RingTheory.MvPolynomial.Homogeneous): refactor in terms of weightedHomogeneous #7609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eightedHomogeneous
mariainesdff
added
awaiting-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ver-community/mathlib4 into mariainesdff/homogeneous
Vierkantor
reviewed
Oct 23, 2023
Vierkantor
added
awaiting-author
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
mariainesdff
added
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
✌️ mariainesdff can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Apr 15, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
atarnoam
pushed a commit
that referenced
this pull request
Apr 16, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
semorrison
pushed a commit
that referenced
this pull request
Apr 17, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
semorrison
pushed a commit
that referenced
this pull request
Apr 17, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
Jun2M
pushed a commit
that referenced
this pull request
Apr 24, 2024
…eightedHomogeneous (#7609) We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial. Question: should all uses of `∑ i in d.support, d i` be replaced by `degree d`? Co-authored-by: Antoine Chambert-Loir <antoine.chambert-loir@u-paris.fr> Co-authored-by: María Inés de Frutos-Fernández <88536493+mariainesdff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rewrite the definition of homogeneous polynomial as a special case of weighted homogeneous polynomial.
Question: should all uses of
∑ i in d.support, d ibe replaced bydegree d?Co-authored-by: Antoine Chambert-Loir antoine.chambert-loir@u-paris.fr