Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Basic lemmas about positivity of a • b #7647

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: Basic lemmas about positivity of a • b #7647

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Oct 12, 2023 •
edited

All lemmas and lemma names are taken from their mul counterpart.

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Oct 12, 2023
@YaelDillies YaelDillies mentioned this pull request Oct 12, 2023
Closed
1 task
eric-wieser
eric-wieser reviewed Oct 17, 2023
View reviewed changes
Mathlib/Algebra/Order/SMul.lean
@@ -99,6 +124,9 @@ variable [OrderedSemiring R] [OrderedAddCommMonoid M] [SMulWithZero R M] [Ordere
· exact (smul_lt_smul_of_pos hab hc).le
#align smul_le_smul_of_nonneg smul_le_smul_of_nonneg

-- TODO: Remove `smul_le_smul_of_nonneg` completely
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this? are you just trying to avoid the PR growing due to another rename, or is there a deeper issue?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am just trying to keep this PR contained.

@eric-wieser
Copy link
Member

If these lemma names are all copied directly from the mul versions, can you put that in the PR description? Are there any new lemmas that don't fit that pattern?

@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 17, 2023
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 18, 2023
@alexjbest
Copy link
Member

LGTM

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alexjbest.

@RemyDegenne
Copy link
Contributor

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 30, 2023
bors bot pushed a commit that referenced this pull request Oct 30, 2023
@YaelDillies
feat: Basic lemmas about positivity of a • b (#7647)
baf4bc6 
All lemmas and lemma names are taken from their `mul` counterpart.
@bors
Copy link

bors bot commented Oct 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Basic lemmas about positivity of a • b [Merged by Bors] - feat: Basic lemmas about positivity of a • b Oct 30, 2023
@bors bors bot closed this Oct 30, 2023
@bors bors bot deleted the smul_nonneg_iff branch October 30, 2023 16:19
grunweg pushed a commit that referenced this pull request Nov 1, 2023
@YaelDillies @grunweg
feat: Basic lemmas about positivity of a • b (#7647)
fe9e8eb 
All lemmas and lemma names are taken from their `mul` counterpart.
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
@YaelDillies @fgdorais
feat: Basic lemmas about positivity of a • b (#7647)
569b8a4 
All lemmas and lemma names are taken from their `mul` counterpart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @eric-wieser @alexjbest @RemyDegenne