Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: if X is Gaussian, then X+y and c*X are Gaussian #7674

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat: if X is Gaussian, then X+y and c*X are Gaussian #7674

wants to merge 21 commits into from

Conversation

RemyDegenne
Copy link
Contributor

@RemyDegenne RemyDegenne commented Oct 14, 2023 •
edited by sgouezel
Loading

@RemyDegenne RemyDegenne added WIP Work in progress blocked-by-other-PR This PR depends on another PR to Mathlib t-measure-probability Measure theory / Probability theory labels Oct 14, 2023
@RemyDegenne RemyDegenne mentioned this pull request Oct 14, 2023
Closed
1 task
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Oct 15, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 16, 2023
@RemyDegenne RemyDegenne added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Oct 17, 2023
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Oct 17, 2023
@RemyDegenne RemyDegenne removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 18, 2023
@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Oct 18, 2023
sgouezel
sgouezel reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Mathlib/Probability/Distributions/Gaussian.lean Outdated Show resolved Hide resolved
Mathlib/Probability/Distributions/Gaussian.lean Outdated Show resolved Hide resolved
Mathlib/Probability/Distributions/Gaussian.lean Outdated Show resolved Hide resolved
Mathlib/Probability/Distributions/Gaussian.lean Outdated Show resolved Hide resolved
@digama0
Copy link
Member

digama0 commented Oct 21, 2023

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

sgouezel
sgouezel reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me, thanks!
I wonder if we should introduce some notation or some definition for Measure.map X ℙ in the probabilistic setting, to make the last statements more readable, but there is already enough in this PR.
bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 30, 2023
bors bot pushed a commit that referenced this pull request Oct 30, 2023
@RemyDegenne @digama0
feat: if X is Gaussian, then X+y and c*X are Gaussian (#7674)
185dddf 
Co-authored-by: Alexander Bentkamp



Co-authored-by: RemyDegenne <remydegenne@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@bors
Copy link

bors bot commented Oct 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: if X is Gaussian, then X+y and c*X are Gaussian [Merged by Bors] - feat: if X is Gaussian, then X+y and c*X are Gaussian Oct 30, 2023
@bors bors bot closed this Oct 30, 2023
@bors bors bot deleted the RD_gaussian_map branch October 30, 2023 15:05
grunweg pushed a commit that referenced this pull request Nov 1, 2023
@RemyDegenne @digama0 @grunweg
feat: if X is Gaussian, then X+y and c*X are Gaussian (#7674)
b59290a 
Co-authored-by: Alexander Bentkamp



Co-authored-by: RemyDegenne <remydegenne@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
@RemyDegenne @digama0 @fgdorais
feat: if X is Gaussian, then X+y and c*X are Gaussian (#7674)
e00ef7c 
Co-authored-by: Alexander Bentkamp



Co-authored-by: RemyDegenne <remydegenne@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-measure-probability Measure theory / Probability theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RemyDegenne @leanprover-community-mathlib4-bot @digama0 @eric-wieser @sgouezel