Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(Tactic/Cases): fix context for induction' #7684

Closed
wants to merge 5 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Oct 14, 2023

Adding a test case for induction' that failed and fixing it: induction' a would accidentally leave a and variables depending on a in context.


This is the example that's been added to the test cases:

example (a b : ℕ) (h : a + b = a) : b = 0 := by
  induction' a with d hd
  · sorry
  · -- bad context:
    -- a b: ℕ
    -- h✝: a + b = a
    -- d: ℕ
    -- hd: d + b = d → b = 0
    -- h: Nat.succ d + b = Nat.succ d
    -- ⊢ b = 0
    sorry

See Zulip thread

Open in Gitpod

@joneugster joneugster added awaiting-review The author would like community review of the PR t-meta Tactics, attributes or user commands labels Oct 14, 2023
@joneugster joneugster changed the title fix(Tactic.Cases): fix context for induction' fix(Tactic/Cases): fix context for induction' Oct 14, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Oct 14, 2023

✌️ joneugster can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 14, 2023
@joneugster joneugster added awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR labels Oct 15, 2023
@joneugster
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 15, 2023
Adding a test case for `induction'` that failed and fixing it: `induction' a` would accidentally leave `a` and variables depending on `a` in context.
@bors
Copy link

bors bot commented Oct 15, 2023

Build failed:

@semorrison
Copy link
Contributor

@joneugster do you want to merge master, and see if there is a problem, and then send it to bors again?

@joneugster
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Oct 23, 2023
Adding a test case for `induction'` that failed and fixing it: `induction' a` would accidentally leave `a` and variables depending on `a` in context.
@bors
Copy link

bors bot commented Oct 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title fix(Tactic/Cases): fix context for induction' [Merged by Bors] - fix(Tactic/Cases): fix context for induction' Oct 23, 2023
@bors bors bot closed this Oct 23, 2023
@bors bors bot deleted the eugster/induction-prime-generalised-vars branch October 23, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants