Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Control/Functor): port file #769

Closed
wants to merge 1 commit into from

Conversation

j-loreaux
Copy link
Collaborator

mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

Notes:

  1. There is a discrepancy between the Lean 3 and Lean 4 types of has_seq.seq and Seq.seq. I added an for alignment.
  2. There were one or two places where the existing simp or rw calls didn't succeed, but I'm not entirely sure why.
  3. In Functor.Comp.functor_comp_id and Functor.Comp.functor_id_comp I had to use Id instead of id, because only the former has the Monad instance.
  4. I had to change the imports, but I think what is there now is minimal.

Note: this is a literal duplicate of #612 created in an attempt to circumvent build failures

@semorrison
Copy link
Contributor

This PR/issue depends on:

@j-loreaux j-loreaux closed this Nov 28, 2022
@int-y1 int-y1 deleted the j-loreaux/control.functor2 branch April 16, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants