[Merged by Bors] - fix: add missing DecidableEq arguments
#7702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These make the lemmas strictly more (syntactically) general. As usual, the way to find these is to remove `open Classical` and fix what breaks.
eric-wieser
added
awaiting-review
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
These make the lemmas strictly more (syntactically) general. As usual, the way to find these is to remove `open Classical` and fix what breaks. Usually this means adding `classical` to the start of the proof, but there are lots of weird term-mode proofs here for which adding a more surgical `letI := Classical.decEq` is easier.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
DecidableEq argumentsDecidableEq arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These make the lemmas strictly more (syntactically) general.
As usual, the way to find these is to remove
open Classicaland fix what breaks.Usually this means adding
classicalto the start of the proof, but there are lots of weird term-mode proofs here for which adding a more surgicalletI := Classical.decEqis easier.