Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: some measure preserving equivalences on pi-types #7751

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: some measure preserving equivalences on pi-types #7751

wants to merge 3 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Oct 18, 2023 •
edited

Co-authored-by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com

Open in Gitpod

@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR awaiting-CI labels Oct 18, 2023
eric-wieser
eric-wieser approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/MeasureTheory/Constructions/Pi.lean
[∀ i, MeasureSpace (α i)] [∀ i, SigmaFinite (volume : Measure (α i))] (p : ι → Prop)
[DecidablePred p] : MeasurePreserving (MeasurableEquiv.piEquivPiSubtypeProd α p) :=
measurePreserving_piEquivPiSubtypeProd (fun _ => volume) p
#align measure_theory.volume_preserving_pi_equiv_pi_subtype_prod MeasureTheory.volume_preserving_piEquivPiSubtypeProd

theorem measurePreserving_piCongrLeft (f : ι' ≃ ι) :
MeasurePreserving (MeasurableEquiv.piCongrLeft α f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this PR, since you're following the existing pattern, but... Shouldn't this be stated in the less-bundled way as:

Suggested change
MeasurePreserving (MeasurableEquiv.piCongrLeft α f)
MeasurePreserving (Equiv.piCongrLeft α f)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I want to use both the MeasurableEquiv and MeasurePreserving parts at the same time when applying this theorem:
https://leanprover-community.github.io/mathlib4_docs/Mathlib/MeasureTheory/Integral/Lebesgue.html#MeasureTheory.MeasurePreserving.lintegral_map_equiv

That is easier to apply if this is formulated using MeasurableEquiv.

@bors
Copy link

bors bot commented Oct 19, 2023

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 19, 2023
@fpvandoorn
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 19, 2023
bors bot pushed a commit that referenced this pull request Oct 19, 2023
@fpvandoorn
feat: some measure preserving equivalences on pi-types (#7751)
58a6689 
* Also fix the statement of some lemmas of an earlier PR.
* From the Sobolev project
* There are more that depend on #7341 

Co-authored-by: Heather Macbeth 25316162+hrmacbeth@users.noreply.github.com
@bors
Copy link

bors bot commented Oct 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: some measure preserving equivalences on pi-types [Merged by Bors] - feat: some measure preserving equivalences on pi-types Oct 19, 2023
@bors bors bot closed this Oct 19, 2023
@bors bors bot deleted the sobolev_pi branch October 19, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpvandoorn @eric-wieser @leanprover-community-mathlib4-bot