Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: protect Int.xor #7757

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: protect Int.xor #7757

wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Oct 18, 2023 •
edited

This cleans up some local notation needed to work around the clash with the Bool xor in the root namespace.

Open in Gitpod

@eric-wieser
chore: protect Int.xor
9c8ed55 
This cleans up some local notation needed to work around the clash.
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Oct 18, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 19, 2023
@eric-wieser eric-wieser removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 19, 2023
jcommelin
jcommelin approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Oct 19, 2023
bors bot pushed a commit that referenced this pull request Oct 19, 2023
@eric-wieser
chore: protect Int.xor (#7757)
924eae1 
This cleans up some local notation needed to work around the clash with the `Bool` `xor` in the root namespace.
@bors
Copy link

bors bot commented Oct 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: protect Int.xor [Merged by Bors] - chore: protect Int.xor Oct 19, 2023
@bors bors bot closed this Oct 19, 2023
@bors bors bot deleted the eric-wieser/remove-bxor branch October 19, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @jcommelin @leanprover-community-mathlib4-bot