Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: miscellaneous Lie algebra lemmas #7782

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: miscellaneous Lie algebra lemmas #7782

wants to merge 3 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Oct 19, 2023

Open in Gitpod

@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Oct 19, 2023
jcommelin
jcommelin approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Oct 19, 2023

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 19, 2023
@ocfnash
Copy link
Contributor Author

ocfnash commented Oct 19, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 19, 2023
eric-wieser
eric-wieser reviewed Oct 19, 2023
View reviewed changes
Mathlib/Algebra/Lie/Basic.lean

instance Module.Dual.instLieModule : LieModule R L (M →ₗ[R] R) where
smul_lie := fun t x m ↦ by ext n; simp
lie_smul := fun t x m ↦ by ext n; simp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: arguably more readable as

Suggested change
lie_smul := fun t x m ↦ by ext n; simp
lie_smul t x m := by ext n; simp

(Throughout)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to cancel the merge though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, noted for the future.

bors bot pushed a commit that referenced this pull request Oct 19, 2023
@ocfnash
feat: miscellaneous Lie algebra lemmas (#7782)
9eb25ab
@bors
Copy link

bors bot commented Oct 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: miscellaneous Lie algebra lemmas [Merged by Bors] - feat: miscellaneous Lie algebra lemmas Oct 19, 2023
@bors bors bot closed this Oct 19, 2023
@bors bors bot deleted the ocfnash/lie_misc branch October 19, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocfnash @eric-wieser @jcommelin @leanprover-community-mathlib4-bot