[Merged by Bors] - refactor: List.All₂ to List.Forall #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames `List.All₂` to `List.Forall`, because the `₂` is highly confusing when it usually means “two lists”, and we had users on Zulip not find `List.Forall` because of that (<https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Is.20there.20List.2EForall.E2.82.82.2C.20but.20for.20one.20list.3F.20.28In.20library.20Std.29/near/397551365>) This also * Switches to primitive recursion, so that `all₂_cons` holds definitially and can be dropped * Updates all affected proofs * In `NumberTheory/Dioph`, a non-terminal `simp at d` could be removed completely because of this defeq. * I also `simp-only`ied another non-terminal `simp` there.
nomeata
added
the
awaiting-review
eric-wieser
reviewed
Oct 20, 2023
eric-wieser
reviewed
Oct 20, 2023
eric-wieser
reviewed
Oct 21, 2023
|
✌️ nomeata can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
This renames `List.All₂` to `List.Forall`, because the `₂` is highly confusing when it usually means “two lists”, and we had users on Zulip not find `List.Forall` because of that (<https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Is.20there.20List.2EForall.E2.82.82.2C.20but.20for.20one.20list.3F.20.28In.20library.20Std.29/near/397551365>)
|
Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause |
|
Canceled. |
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 21, 2023
This renames `List.All₂` to `List.Forall`, because the `₂` is highly confusing when it usually means “two lists”, and we had users on Zulip not find `List.Forall` because of that (<https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Is.20there.20List.2EForall.E2.82.82.2C.20but.20for.20one.20list.3F.20.28In.20library.20Std.29/near/397551365>) Co-authored-by: Mario Carneiro <di.gama@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Oct 22, 2023
This renames `List.All₂` to `List.Forall`, because the `₂` is highly confusing when it usually means “two lists”, and we had users on Zulip not find `List.Forall` because of that (<https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Is.20there.20List.2EForall.E2.82.82.2C.20but.20for.20one.20list.3F.20.28In.20library.20Std.29/near/397551365>) Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
List.All₂toList.Forall, because the₂is highlyconfusing when it usually means “two lists”, and we had users on Zulip
not find
List.Forallbecause of that(https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Is.20there.20List.2EForall.E2.82.82.2C.20but.20for.20one.20list.3F.20.28In.20library.20Std.29/near/397551365)