Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add gcongr lemmas for Nat.floor, Nat.ceil, Int.floor, Int.ceil #7811

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat: add gcongr lemmas for Nat.floor, Nat.ceil, Int.floor, Int.ceil #7811

wants to merge 2 commits into from

Conversation

dupuisf
Copy link
Contributor

@dupuisf dupuisf commented Oct 21, 2023

The lemmas are just restatements of lemmas of the form Monotone Nat.floor etc, but these cannot be tagged directly with the gcongr attribute.

Open in Gitpod

@dupuisf dupuisf added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Oct 21, 2023
@digama0
Copy link
Member

digama0 commented Oct 21, 2023

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

@hrmacbeth
Copy link
Member

This looks good to me except for the spurious toolchain edit introduced by Mario's commit. Not sure it matters, but can you merge master before merging?

bors d+

@bors
Copy link

bors bot commented Oct 23, 2023

✌️ dupuisf can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Oct 23, 2023
@digama0
Copy link
Member

digama0 commented Oct 23, 2023

@hrmacbeth Just FYI, but bors will automatically merge master so the toolchain edit shouldn't get in the way. (If a PR stalls for long enough for a new RC to come out, the toolchain edit will likely cause a merge conflict, and in that case you will need to manually merge master.)

@hrmacbeth
Copy link
Member

Ok, great!

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 23, 2023
bors bot pushed a commit that referenced this pull request Oct 23, 2023
@dupuisf @digama0
feat: add gcongr lemmas for Nat.floor, Nat.ceil, Int.floor, `In…
49b7459 
…t.ceil` (#7811)

The lemmas are just restatements of lemmas of the form `Monotone Nat.floor` etc, but these cannot be tagged directly with the gcongr attribute.



Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@bors
Copy link

bors bot commented Oct 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: add gcongr lemmas for Nat.floor, Nat.ceil, Int.floor, Int.ceil [Merged by Bors] - feat: add gcongr lemmas for Nat.floor, Nat.ceil, Int.floor, Int.ceil Oct 23, 2023
@bors bors bot closed this Oct 23, 2023
@bors bors bot deleted the dupuisf/floor_gcongr branch October 23, 2023 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dupuisf @digama0 @hrmacbeth