Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: add docstring on says syntax #7818

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore: add docstring on says syntax #7818

wants to merge 5 commits into from

Conversation

semorrison
Copy link
Contributor

Open in Gitpod

@robertylewis robertylewis added documentation Improvements or additions to documentation awaiting-author A reviewer has asked the author a question or requested changes labels Oct 21, 2023
@digama0
Copy link
Member

digama0 commented Oct 21, 2023

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

@semorrison semorrison added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 21, 2023
@robertylewis
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 22, 2023
bors bot pushed a commit that referenced this pull request Oct 22, 2023
@semorrison @digama0 @robertylewis
chore: add docstring on says syntax (#7818)
5c9a285 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
@bors
Copy link

bors bot commented Oct 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: add docstring on says syntax [Merged by Bors] - chore: add docstring on says syntax Oct 22, 2023
@bors bors bot closed this Oct 22, 2023
@bors bors bot deleted the says_docstring branch October 22, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @digama0 @robertylewis @jcommelin