Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(CategoryTheory): allow diagram chases by arguing up to refinements #7821

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(CategoryTheory): allow diagram chases by arguing up to refinements #7821

wants to merge 6 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Oct 21, 2023 •
edited
Loading

This PR introduces the most basic results which enable doing diagram chases in general abelian categories by arguing "up to refinements".

See also https://leanprover.zulipchat.com/#narrow/stream/335062-homology/topic/Diagram.20chases.20in.20general.20abelian.20categories

Open in Gitpod

@joelriou joelriou added the t-category-theory Category theory label Oct 21, 2023
@joelriou joelriou mentioned this pull request Oct 21, 2023
Open
@digama0
Copy link
Member

digama0 commented Oct 21, 2023

Note: I have pushed an update to the lean toolchain because this PR was on a buggy version of the toolchain. WARNING: checking out old commits of this PR using v4.2.0-rc2 or v4.2.0-rc3 can cause lake clean to delete your mathlib folder! If you need to do so, make sure to delete lakefile.olean manually before running any lake commands.

jcommelin
jcommelin reviewed Oct 27, 2023
View reviewed changes
Mathlib/Algebra/Homology/ShortComplex/Refinements.lean Outdated
Comment on lines 37 to 39
arguing locally for a Grothendieck topology. It is even likely that
it is a particular case (consider the canonical topology on
the abelian category `C`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to turn this into a TODO? Or phrase it more directly as a question that can be investigated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have turned it into a TODO, with a more precise formulation.

Mathlib/Algebra/Homology/ShortComplex/Refinements.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Oct 27, 2023
@joelriou joelriou added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Oct 28, 2023
jcommelin
jcommelin approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 30, 2023
bors bot pushed a commit that referenced this pull request Oct 30, 2023
@joelriou @digama0
feat(CategoryTheory): allow diagram chases by arguing up to refinemen…
0121543 
…ts (#7821)

This PR introduces the most basic results which enable doing diagram chases in general abelian categories by arguing "up to refinements".



Co-authored-by: Mario Carneiro <di.gama@gmail.com>
@bors
Copy link

bors bot commented Oct 30, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat(CategoryTheory): allow diagram chases by arguing up to refinements [Merged by Bors] - feat(CategoryTheory): allow diagram chases by arguing up to refinements Oct 30, 2023
@bors bors bot closed this Oct 30, 2023
@bors bors bot deleted the refinements branch October 30, 2023 16:18
grunweg pushed a commit that referenced this pull request Nov 1, 2023
@joelriou @digama0 @grunweg
feat(CategoryTheory): allow diagram chases by arguing up to refinemen…
7093df4 
…ts (#7821)

This PR introduces the most basic results which enable doing diagram chases in general abelian categories by arguing "up to refinements".



Co-authored-by: Mario Carneiro <di.gama@gmail.com>
fgdorais pushed a commit that referenced this pull request Nov 1, 2023
@joelriou @digama0 @fgdorais
feat(CategoryTheory): allow diagram chases by arguing up to refinemen…
76c54dc 
…ts (#7821)

This PR introduces the most basic results which enable doing diagram chases in general abelian categories by arguing "up to refinements".



Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelriou @digama0 @jcommelin @leanprover-community-mathlib4-bot